func icon indicating copy to clipboard operation
func copied to clipboard

S2I (source-to-image) host binds

Open matejvasek opened this issue 7 months ago • 3 comments

Changes

  • :gift: Added host binds for S2I build

matejvasek avatar Apr 02 '25 19:04 matejvasek

PTAL @lkingland @gauron99 @matzew

matejvasek avatar Apr 02 '25 19:04 matejvasek

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.45%. Comparing base (2d39624) to head (1c3b423). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/builders/s2i/builder.go 50.00% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2766      +/-   ##
==========================================
+ Coverage   61.60%   62.45%   +0.84%     
==========================================
  Files         131      131              
  Lines       15764    15770       +6     
==========================================
+ Hits         9712     9849     +137     
+ Misses       5142     4982     -160     
- Partials      910      939      +29     
Flag Coverage Δ
e2e-test 35.32% <0.00%> (-0.02%) :arrow_down:
e2e-test-oncluster 33.75% <0.00%> (+1.39%) :arrow_up:
e2e-test-oncluster-runtime 28.14% <0.00%> (?)
e2e-test-runtime-go 25.68% <50.00%> (?)
e2e-test-runtime-node 25.05% <50.00%> (?)
e2e-test-runtime-quarkus 25.19% <50.00%> (?)
e2e-test-runtime-rust 24.70% <0.00%> (?)
e2e-test-runtime-springboot 24.74% <0.00%> (?)
e2e-test-runtime-typescript 25.19% <50.00%> (?)
integration-tests 48.68% <50.00%> (+1.81%) :arrow_up:
unit-tests 48.64% <50.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 02 '25 19:04 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Apr 03 '25 09:04 knative-prow[bot]