func
func copied to clipboard
Updated git-clone task
Changes
- Updated git fetch task to newer version that is now rootless.
This changes are also already included in the "Go s2i on cluster build" PR.
@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.
In response to this:
Changes
/kind
Fixes #
Release Note
Docs
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: matejvasek
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [matejvasek]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 50.64%. Comparing base (
8f7dd2c) to head (20bd907). Report is 142 commits behind head on main.
:exclamation: There is a different number of reports uploaded between BASE (8f7dd2c) and HEAD (20bd907). Click for more details.
HEAD has 6 uploads less than BASE
Flag BASE (8f7dd2c) HEAD (20bd907) unit-tests-macos-latest 1 0 unit-tests-ubuntu-latest 1 0 unit-tests-windows-latest 1 0 e2e-test 1 0 integration-tests 1 0 e2e-test-oncluster 1 0
Additional details and impacted files
@@ Coverage Diff @@
## main #2469 +/- ##
===========================================
- Coverage 61.19% 50.64% -10.56%
===========================================
Files 130 128 -2
Lines 15354 11933 -3421
===========================================
- Hits 9396 6043 -3353
- Misses 5032 5183 +151
+ Partials 926 707 -219
| Flag | Coverage Δ | |
|---|---|---|
| e2e-test | ? |
|
| e2e-test-oncluster | ? |
|
| integration-tests | ? |
|
| unit-tests-macos-latest | ? |
|
| unit-tests-ubuntu-latest | ? |
|
| unit-tests-windows-latest | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PTAL @lkingland @matzew @gauron99
/hold
@lkingland we may also opt not to do this update and keep rootfull git-clone. We just will have to also make func-utils image rootfull to. See https://github.com/knative/func/pull/2471
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.