func icon indicating copy to clipboard operation
func copied to clipboard

fix: HOME with different permissions

Open gauron99 opened this issue 1 year ago • 3 comments

Make sure standard functionality works even when HOME has different permissions

  • added new tests

/kind enhancement

gauron99 avatar Jun 13 '24 09:06 gauron99

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

knative-prow[bot] avatar Jun 13 '24 09:06 knative-prow[bot]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.10%. Comparing base (f4bd1d8) to head (1fbb2a8). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/root.go 33.33% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2361      +/-   ##
==========================================
+ Coverage   61.54%   67.10%   +5.55%     
==========================================
  Files         129      129              
  Lines       15334    11931    -3403     
==========================================
- Hits         9437     8006    -1431     
+ Misses       4971     2962    -2009     
- Partials      926      963      +37     
Flag Coverage Δ
e2e-test 36.65% <66.66%> (-0.01%) :arrow_down:
e2e-test-oncluster 33.44% <66.66%> (+0.01%) :arrow_up:
e2e-test-oncluster-runtime 29.57% <66.66%> (?)
e2e-test-runtime-go 26.62% <66.66%> (?)
e2e-test-runtime-node 26.00% <66.66%> (?)
e2e-test-runtime-python 26.00% <66.66%> (?)
e2e-test-runtime-quarkus 26.10% <66.66%> (?)
e2e-test-runtime-rust 25.15% <66.66%> (?)
e2e-test-runtime-springboot 25.18% <66.66%> (?)
e2e-test-runtime-typescript 26.09% <66.66%> (?)
integration-tests 53.14% <50.00%> (+2.41%) :arrow_up:
unit-tests 51.28% <50.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 13 '24 09:06 codecov[bot]

/rerun all

gauron99 avatar Aug 08 '24 07:08 gauron99

/test all

gauron99 avatar Aug 08 '24 07:08 gauron99

/retest-required

gauron99 avatar Aug 08 '24 07:08 gauron99

/retest-required

gauron99 avatar Aug 12 '24 11:08 gauron99

The main unit test is failing because "knative" user (GH actions/ something similar) has greater permissions, I suspect. Will have to update the new test.

gauron99 avatar Aug 14 '24 09:08 gauron99

@lkingland PTAL

I have moved the printing to the root.go file which significantly lowers the number of prints to just one per command. I have also added a TODO for myself for the opportunity to simplify the whole process.

gauron99 avatar Sep 09 '24 06:09 gauron99

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [gauron99,lkingland]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Sep 09 '24 07:09 knative-prow[bot]

/unhold

gauron99 avatar Sep 09 '24 07:09 gauron99