Replace container to due errors

[matzew]

Changes

Fixes #2358

• Replace container to due errors

/kind

Fixes #

Release Note

Docs

[knative-prow[bot]]

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

Fixes #2358

• Replace container to due errors

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [matzew]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.71%. Comparing base (a18957d) to head (659158f). Report is 141 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2359      +/-   ##
==========================================
+ Coverage   58.34%   65.71%   +7.36%     
==========================================
  Files         128      128              
  Lines       14895    11534    -3361     
==========================================
- Hits         8690     7579    -1111     
+ Misses       5304     2999    -2305     
- Partials      901      956      +55     

Flag	Coverage Δ
e2e-test	37.99% <ø> (ø)
e2e-test-oncluster	?
e2e-test-oncluster-runtime	27.01% <ø> (?)
e2e-test-runtime-go	26.03% <ø> (?)
e2e-test-runtime-node	27.00% <ø> (?)
e2e-test-runtime-python	27.00% <ø> (?)
e2e-test-runtime-quarkus	27.10% <ø> (?)
e2e-test-runtime-rust	26.08% <ø> (?)
e2e-test-runtime-springboot	26.14% <ø> (?)
e2e-test-runtime-typescript	27.09% <ø> (?)
integration-tests	51.34% <ø> (?)
unit-tests	49.30% <ø> (?)
unit-tests-macos-latest	?
unit-tests-ubuntu-latest	?
unit-tests-windows-latest	?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[matejvasek]

I think it might be better to just check if the container already exist and if it does then skip creation. Current approach only fixes the issue for podman and it deletes all stored images which may or may not be desirable.

[matejvasek]

ping @matzew

[github-actions[bot]]

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.