func icon indicating copy to clipboard operation
func copied to clipboard

Remove axios dependency

Open matejvasek opened this issue 1 year ago • 10 comments

Changes

  • Removed dependency on axios by using fetch().
  • Fixed getLatestPlatform() by using the tag_name property instead of the name property.

matejvasek avatar May 07 '24 14:05 matejvasek

PTAL @trisberg @lkingland @matzew

matejvasek avatar May 07 '24 14:05 matejvasek

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.72%. Comparing base (b97d841) to head (37d6749). Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
- Coverage   64.21%   60.72%   -3.50%     
==========================================
  Files         108      127      +19     
  Lines       13918    14779     +861     
==========================================
+ Hits         8937     8974      +37     
- Misses       4108     4905     +797     
- Partials      873      900      +27     
Flag Coverage Δ
e2e-test 38.44% <ø> (+1.06%) :arrow_up:
e2e-test-oncluster 31.52% <ø> (+1.01%) :arrow_up:
e2e-test-oncluster-runtime 27.67% <ø> (?)
e2e-test-runtime-go 26.21% <ø> (?)
e2e-test-runtime-node 27.22% <ø> (?)
e2e-test-runtime-python 27.17% <ø> (?)
e2e-test-runtime-quarkus 27.26% <ø> (?)
e2e-test-runtime-rust 26.29% <ø> (?)
e2e-test-runtime-springboot 26.35% <ø> (?)
e2e-test-runtime-typescript 27.34% <ø> (?)
integration-tests 49.93% <ø> (+0.07%) :arrow_up:
unit-tests-macos-latest ?
unit-tests-ubuntu-latest 48.98% <ø> (-0.61%) :arrow_down:
unit-tests-windows-latest 47.60% <ø> (-1.27%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 14:05 codecov[bot]

@trisberg Why the newer Spring Boot works only with Java 17 not 21?

matejvasek avatar May 07 '24 14:05 matejvasek

@trisberg Why the newer Spring Boot works only with Java 17 not 21?

It should work with Java 21, I use that all the time. What is the error and the failing config?

trisberg avatar May 07 '24 15:05 trisberg

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 07 '24 15:05 knative-prow[bot]

/lgtm /hold for potential fix enabling Java 21

lkingland avatar May 07 '24 15:05 lkingland

@trisberg Why the newer Spring Boot works only with Java 17 not 21?

It should work with Java 21, I use that all the time. What is the error and the failing config?

oops I probably used old version of Java when testing locally

matejvasek avatar May 07 '24 16:05 matejvasek

PTAL @lkingland

matejvasek avatar May 07 '24 16:05 matejvasek

/unhold

matejvasek avatar May 07 '24 16:05 matejvasek

I have idea why the coverage fails. @dsimansk @ReToCode please override it.

matejvasek avatar May 08 '24 14:05 matejvasek

/lgtm

lkingland avatar May 09 '24 01:05 lkingland

/override codecov/project

matejvasek avatar May 10 '24 17:05 matejvasek

@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators.

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar May 10 '24 17:05 knative-prow[bot]

Why the **** is there codecov/project twice?

matejvasek avatar May 10 '24 17:05 matejvasek

I just created completely new PR.

matejvasek avatar May 11 '24 00:05 matejvasek