Remove axios dependency
Changes
- Removed dependency on
axiosby usingfetch(). - Fixed
getLatestPlatform()by using thetag_nameproperty instead of thenameproperty.
PTAL @trisberg @lkingland @matzew
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 60.72%. Comparing base (
b97d841) to head (37d6749). Report is 79 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2293 +/- ##
==========================================
- Coverage 64.21% 60.72% -3.50%
==========================================
Files 108 127 +19
Lines 13918 14779 +861
==========================================
+ Hits 8937 8974 +37
- Misses 4108 4905 +797
- Partials 873 900 +27
| Flag | Coverage Δ | |
|---|---|---|
| e2e-test | 38.44% <ø> (+1.06%) |
:arrow_up: |
| e2e-test-oncluster | 31.52% <ø> (+1.01%) |
:arrow_up: |
| e2e-test-oncluster-runtime | 27.67% <ø> (?) |
|
| e2e-test-runtime-go | 26.21% <ø> (?) |
|
| e2e-test-runtime-node | 27.22% <ø> (?) |
|
| e2e-test-runtime-python | 27.17% <ø> (?) |
|
| e2e-test-runtime-quarkus | 27.26% <ø> (?) |
|
| e2e-test-runtime-rust | 26.29% <ø> (?) |
|
| e2e-test-runtime-springboot | 26.35% <ø> (?) |
|
| e2e-test-runtime-typescript | 27.34% <ø> (?) |
|
| integration-tests | 49.93% <ø> (+0.07%) |
:arrow_up: |
| unit-tests-macos-latest | ? |
|
| unit-tests-ubuntu-latest | 48.98% <ø> (-0.61%) |
:arrow_down: |
| unit-tests-windows-latest | 47.60% <ø> (-1.27%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@trisberg Why the newer Spring Boot works only with Java 17 not 21?
@trisberg Why the newer Spring Boot works only with Java 17 not 21?
It should work with Java 21, I use that all the time. What is the error and the failing config?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lkingland, matejvasek
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [lkingland,matejvasek]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/lgtm /hold for potential fix enabling Java 21
@trisberg Why the newer Spring Boot works only with Java 17 not 21?
It should work with Java 21, I use that all the time. What is the error and the failing config?
oops I probably used old version of Java when testing locally
PTAL @lkingland
/unhold
I have idea why the coverage fails. @dsimansk @ReToCode please override it.
/lgtm
/override codecov/project
@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators.
In response to this:
/override codecov/project
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Why the **** is there codecov/project twice?
I just created completely new PR.