func icon indicating copy to clipboard operation
func copied to clipboard

WIP use image index not just image

Open matejvasek opened this issue 1 year ago • 3 comments

matejvasek avatar Apr 30 '24 17:04 matejvasek

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

knative-prow[bot] avatar Apr 30 '24 17:04 knative-prow[bot]

Codecov Report

Attention: Patch coverage is 60.41667% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 65.68%. Comparing base (0857f0c) to head (9a0bab3). Report is 1 commits behind head on main.

Files Patch % Lines
pkg/docker/pusher.go 60.41% 10 Missing and 9 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
+ Coverage   60.16%   65.68%   +5.51%     
==========================================
  Files         128      128              
  Lines       14835    11531    -3304     
==========================================
- Hits         8926     7574    -1352     
+ Misses       4994     2998    -1996     
- Partials      915      959      +44     
Flag Coverage Δ
e2e-test 38.02% <56.25%> (+0.02%) :arrow_up:
e2e-test-oncluster 31.22% <56.25%> (+0.04%) :arrow_up:
e2e-test-oncluster-runtime 26.92% <0.00%> (?)
e2e-test-runtime-go 26.05% <56.25%> (?)
e2e-test-runtime-node 27.04% <56.25%> (?)
e2e-test-runtime-python 27.04% <56.25%> (?)
e2e-test-runtime-quarkus 27.14% <56.25%> (?)
e2e-test-runtime-rust 26.09% <56.25%> (?)
e2e-test-runtime-springboot 26.19% <56.25%> (?)
e2e-test-runtime-typescript 27.13% <56.25%> (?)
integration-tests 51.30% <0.00%> (+2.29%) :arrow_up:
unit-tests 49.24% <60.41%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 30 '24 17:04 codecov[bot]

PTAL @lkingland @gauron99 @matzew

matejvasek avatar May 28 '24 11:05 matejvasek

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 28 '24 13:05 knative-prow[bot]

@ReToCode @dsimansk please override "On Cluster RT Test (ubuntu-latest, s2i)".

matejvasek avatar May 28 '24 14:05 matejvasek

/override "On Cluster RT Test (ubuntu-latest, s2i)"

dsimansk avatar May 28 '24 14:05 dsimansk

@dsimansk: Overrode contexts on behalf of dsimansk: On Cluster RT Test (ubuntu-latest, s2i)

In response to this:

/override "On Cluster RT Test (ubuntu-latest, s2i)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar May 28 '24 14:05 knative-prow[bot]