func icon indicating copy to clipboard operation
func copied to clipboard

feat: s2i builder go support

Open lkingland opened this issue 1 year ago • 4 comments

Changes

  • :gift: S2I Go support

/kind enhancement

Fixes #

Release Note


Docs


lkingland avatar Mar 05 '24 05:03 lkingland

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

knative-prow[bot] avatar Mar 05 '24 05:03 knative-prow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Mar 05 '24 05:03 knative-prow[bot]

Codecov Report

Attention: Patch coverage is 57.57576% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 58.61%. Comparing base (e6fa020) to head (c5bebc3).

Files Patch % Lines
pkg/builders/s2i/builder.go 56.66% 15 Missing and 11 partials :warning:
pkg/builders/s2i/assemblers.go 66.66% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2203      +/-   ##
==========================================
- Coverage   60.17%   58.61%   -1.57%     
==========================================
  Files         127      126       -1     
  Lines       14784    11479    -3305     
==========================================
- Hits         8896     6728    -2168     
+ Misses       4981     3786    -1195     
- Partials      907      965      +58     
Flag Coverage Δ
e2e-test 38.02% <0.00%> (-0.12%) :arrow_down:
e2e-test-oncluster 31.17% <0.00%> (-0.11%) :arrow_down:
e2e-test-oncluster-runtime 27.17% <0.00%> (?)
integration-tests 50.16% <57.57%> (+1.19%) :arrow_up:
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 10 '24 02:04 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar May 13 '24 15:05 knative-prow-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [gauron99,lkingland]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 20 '24 19:05 knative-prow[bot]