func icon indicating copy to clipboard operation
func copied to clipboard

Support configuration of the `lifecycle` image

Open braunsonm opened this issue 1 year ago • 6 comments

When you run a build with the func CLI using your own builder it will attempt to pull the lifecycle binaries from quay.io. This may be because the builder is not trusted

However it doesn't seem that the func CLI respects the list of trusted builders that a user configures with the Pack CLI, and also does not allow configuration of this property itself. This means that at runtime func will attempt to pull the lifecycle from quay.io. The image that func pulls is hardcoded here: https://github.com/knative/func/blob/51f7a70b9a750f0509b79940a3c9628696ffc688/pkg/builders/buildpacks/builder.go#L117

This should allow configuration, or allow configuration of trusted builders so the built in lifecycle binaries can be used.

braunsonm avatar Feb 26 '24 20:02 braunsonm

This seems like a bug to me. I will mark it as such.

It's perhaps worth mentioning that the builder lifecycle image is not intended as "hard-coded" (meaning an unchangable string built into the binary), but rather it is defaulted. This should be an optional user-modifiable setting.

lkingland avatar Mar 21 '24 12:03 lkingland

I agree @lkingland however does func plan to follow the trusted builder methodology I linked from CNB? If so it should just use the included lifecycle binaries if the builder is trusted.

braunsonm avatar Mar 21 '24 14:03 braunsonm

I would like to work on this issue!

EraKin575 avatar Jun 17 '24 08:06 EraKin575

/assign

EraKin575 avatar Jun 17 '24 08:06 EraKin575

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Sep 16 '24 01:09 github-actions[bot]

/remove-lifecycle stale

braunsonm avatar Sep 16 '24 01:09 braunsonm