func icon indicating copy to clipboard operation
func copied to clipboard

Change client.go's `subscription` to better reflect the Trigger Filter attributes

Open matzew opened this issue 1 year ago • 4 comments

Currently the client.go file contains a Subscription:

type Subscription struct {
	Source string `json:"source" yaml:"source"`
	Type   string `json:"type" yaml:"type"`
	Broker string `json:"broker" yaml:"broker"`
}

This struct is wrong, since it only represents the source and/or type attributes on the Trigger.Filter, however that can be anything, no requirement on source or type as a criteria.

matzew avatar Jan 18 '24 09:01 matzew

See also https://github.com/knative/eventing/issues/7265

matzew avatar Jan 18 '24 09:01 matzew

It would be nice, if for func describe things would render like:

Subscriptions (Broker and Attributes):
  my-broker, map[source:/something type:org.apache.camel.event.aws.s3.getObject extension:someOther]

matzew avatar Jan 18 '24 10:01 matzew

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Apr 18 '24 01:04 github-actions[bot]