Propose lifecycle API hooks for Cloudevents SDK

[matzew]

Changes

• Propose lifecycle API hooks for Cloudevents SDK

/kind

Fixes #

Release Note

Docs

[knative-prow[bot]]

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

• Propose lifecycle API hooks for Cloudevents SDK

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matzew]

/hold Let's discuss these hooks, but I think reusing the same APIs from the http version seems to be a good idea

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.18%. Comparing base (b97d841) to head (bc534e7). Report is 103 commits behind head on main.

:exclamation: Current head bc534e7 differs from pull request most recent head 14bb310

Please upload reports for the commit 14bb310 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2120      +/-   ##
==========================================
+ Coverage   64.21%   65.18%   +0.97%     
==========================================
  Files         108      108              
  Lines       13918    13888      -30     
==========================================
+ Hits         8937     9053     +116     
+ Misses       4108     3942     -166     
- Partials      873      893      +20     

Flag	Coverage Δ
e2e-test	37.37% <ø> (-0.01%)	:arrow_down:
e2e-test-oncluster	30.43% <ø> (-0.08%)	:arrow_down:
e2e-test-oncluster-runtime	26.86% <ø> (?)
e2e-test-runtime-go	25.49% <ø> (?)
e2e-test-runtime-node	26.54% <ø> (?)
e2e-test-runtime-python	26.54% <ø> (?)
e2e-test-runtime-quarkus	26.65% <ø> (?)
e2e-test-runtime-rust	25.52% <ø> (?)
e2e-test-runtime-springboot	25.68% <ø> (?)
e2e-test-runtime-typescript	26.65% <ø> (?)
integration-tests	51.82% <ø> (+1.97%)	:arrow_up:
unit-tests-macos-latest	48.82% <ø> (-0.03%)	:arrow_down:
unit-tests-ubuntu-latest	49.59% <ø> (-0.01%)	:arrow_down:
unit-tests-windows-latest	48.89% <ø> (+0.02%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[lkingland]

We'll want to update the instanced CloudEvent function's template in the same PR as the dependency is updated to include that functionality from func-go. When it's tagged and released with a new version which includes the CloudEvents API additions, running make update-runtimes should pull it in

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [matzew]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[matzew]

@lkingland the dependency is now in, and I rebased this

[matzew]

I do have sometimes bunch of new, untracked, files:

gst
On branch propose_lifecycle_hooks_CE
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   generate/zz_filesystem_generated.go
	modified:   third_party/VENDOR-LICENSE/github.com/hashicorp/hcl/go.mod

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	pkg/functions/testdata/migrations/v0.19.0/.gitignore
	pkg/functions/testdata/migrations/v0.23.0-customized/.gitignore
	pkg/functions/testdata/migrations/v0.23.0/.gitignore
	pkg/functions/testdata/migrations/v0.25.0/.gitignore
	pkg/functions/testdata/migrations/v0.34.0/.gitignore
	pkg/functions/testdata/migrations/v0.35.0-nondefault/.gitignore
	pkg/functions/testdata/migrations/v0.35.0/.gitignore
	templates/go/.instanced-cloudevents/go.sum

[matzew]

/hold I am not sure on the untracked files, etc

[knative-prow-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions[bot]]

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.