eventing icon indicating copy to clipboard operation
eventing copied to clipboard

fix: added a function to response labels

Open EraKin575 opened this issue 4 months ago • 5 comments

Fixes #https://github.com/knative/eventing/issues/8649

Proposed Changes

added a functions to add labels to response status in otel metric

Pre-review Checklist

  • [ ] At least 80% unit test coverage
  • [ ] E2E tests for any new behavior
  • [ ] Docs PR for any user-facing impact
  • [ ] Spec PR for any new API feature
  • [ ] Conformance test for any change to the spec

Release Note


Docs

EraKin575 avatar Aug 06 '25 21:08 EraKin575

Hi @EraKin575. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Aug 06 '25 21:08 knative-prow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EraKin575 Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Aug 06 '25 21:08 knative-prow[bot]

Codecov Report

:x: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 51.43%. Comparing base (96629b6) to head (e7a8bc3). :warning: Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
pkg/observability/newcontext.go 0.00% 8 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8658      +/-   ##
==========================================
- Coverage   51.45%   51.43%   -0.02%     
==========================================
  Files         400      400              
  Lines       25138    25146       +8     
==========================================
  Hits        12934    12934              
- Misses      11422    11430       +8     
  Partials      782      782              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 06 '25 21:08 codecov[bot]

hey @EraKin575 just following up on this PR

dprotaso avatar Sep 03 '25 00:09 dprotaso

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Dec 02 '25 01:12 github-actions[bot]