eventing
eventing copied to clipboard
feat: support for additional pod scheduling definition on IntegrationSource
Proposed Changes
- 🎁 #8597
Pre-review Checklist
- [x] At least 80% unit test coverage
- [ ] E2E tests for any new behavior
- [ ] Docs PR for any user-facing impact
- [ ] Spec PR for any new API feature
- [ ] Conformance test for any change to the spec
Release Note
Docs
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: S-Mann / name: Sukhinder Mann (9cc3dba3c627b2b71d2c1628423ef744d8072ccd, 2287ce51cc3a9466171e9005ad453dc5d4bee809, 739e94299dc1ec4bc2f480145cf4d5bdf126ef76, 3f020bd0d7b60966303bc405ab1397dcc80817be, e3ec5dc0d2e36f0e8b867b0f3bf88f626107d3f1, b360265b0054dcc1a59d69466957d1b6fee5c841, 0df51167d11497948900a73b6a4fdca015f12feb, 6a883fd24a6061d8f256a055c03953eb6c92cd9c, 0f0dce4dc2a3b70af3a9383b291d4e80e1856234, 7360e2b863bb97f08a4809578e73b25169de0f73)
Welcome @S-Mann! It looks like this is your first PR to knative/eventing 🎉
Hi @S-Mann. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/cc @Cali0707
/ok-to-test
Codecov Report
Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
Project coverage is 52.29%. Comparing base (
a582a88) to head (6a883fd). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...er/integration/source/resources/containersource.go | 84.21% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #8601 +/- ##
==========================================
- Coverage 52.32% 52.29% -0.03%
==========================================
Files 398 398
Lines 25036 25040 +4
==========================================
- Hits 13099 13094 -5
- Misses 11139 11145 +6
- Partials 798 801 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Cali0707, S-Mann
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Cali0707]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@S-Mann the scaling would also make sense on the IntegrationSink ...