eventing icon indicating copy to clipboard operation
eventing copied to clipboard

[DRAFT] RequestReply: Create InitContainer

Open chaliuu opened this issue 9 months ago • 5 comments

Fixes #8320

Since the RequestReply resource needs a trigger to every pod, rather than to the deployment as a whole, we need to create an InitContainer which creates the trigger to the current pod.

Proposed Changes

  • 🎁 created init container scripts to initialize pods with trigger to themselves.

  • NOTE : NOT TESTED. Blocked by Create Data Plane ticket #8319

Pre-review Checklist

  • [ ] At least 80% unit test coverage
  • [ ] E2E tests for any new behavior
  • [ ] Docs PR for any user-facing impact
  • [ ] Spec PR for any new API feature
  • [ ] Conformance test for any change to the spec

Release Note


Docs

chaliuu avatar Mar 10 '25 18:03 chaliuu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chaliuu Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Mar 10 '25 18:03 knative-prow[bot]

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: chaliuu / name: Charles Liu (03fdb33b4a679bffe2dd4a2759f4479c6eeb0a84, 95a19a6883b0044062496263579395b8ae0fa29d, 709099315835cf968251a86fd45e24e789993eb4)

Welcome @chaliuu! It looks like this is your first PR to knative/eventing 🎉

knative-prow[bot] avatar Mar 10 '25 18:03 knative-prow[bot]

Hi @chaliuu. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Mar 10 '25 18:03 knative-prow[bot]

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jun 23 '25 01:06 github-actions[bot]