Proper way to add Subscription annotations

[csc-piscopo]

Looking for some guidance here on how to properly add annotations to a Subscription, any input would definitely be appreciated.

I am currently trying to add annotations like so to my subscription:

apiVersion: messaging.knative.dev/v1
kind: Subscription
metadata:
  name: seq-blah-sequence-0
  namespace: namespace-xyz
  annotations:
    autoscaling.eventing.knative.dev: "0"
    autoscaling.eventing.knative.dev/cooldown-period: "60"
    autoscaling.eventing.knative.dev/lag-threshold: "100"
    autoscaling.eventing.knative.dev/max-scale: "10"
    autoscaling.eventing.knative.dev/min-scale: "1"
    autoscaling.eventing.knative.dev/polling-interval: "60"

That works briefly until the eventing-controller comes along and stomps on those changes, removing all the custom annotations I have added.

Feels like I am missing something obvious with getting the KEDA autoscaling to work with the Subscription resource. Appreciate any insights!

[matzew]

@csc-piscopo Do you have any logs from the eventing-controller? E.g. does the reconciler for the subscription say anything? Or are there error?

[matzew]

What version are you on?

I am on main (of eventing-k-broker) and I have the autoscaler enabled in (kafka)feature ConfigMapM and I have a KafkaChannel and a sub for that, and those Annotations from above.

But they are not cleaned up for me 🤷

[creydr]

@csc-piscopo any updates on this?

[github-actions[bot]]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.