eventing
eventing copied to clipboard
List applying policies in job sink
Fixes #8062
Proposed Changes
- 🎁 List EventPolicies in the JobSink .status.policies, which apply for it.
- 🎁 Add the EventPoliciesReady condition to indicate, if the referenced policies are Ready
Pre-review Checklist
- [ ] At least 80% unit test coverage
- [ ] E2E tests for any new behavior
- [ ] Docs PR for any user-facing impact
- [ ] Spec PR for any new API feature
- [ ] Conformance test for any change to the spec
Release Note
List applying EventPolicies in JobSink status
Docs
Hi @rahulii. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
Attention: Patch coverage is 52.80899% with 42 lines in your changes missing coverage. Please review.
Project coverage is 68.04%. Comparing base (
96c30bd) to head (d790b54). Report is 5 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #8064 +/- ##
==========================================
+ Coverage 67.92% 68.04% +0.12%
==========================================
Files 366 367 +1
Lines 17154 17249 +95
==========================================
+ Hits 11651 11737 +86
+ Misses 4781 4780 -1
- Partials 722 732 +10
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cc: @creydr @pierDipi
/ok-to-test
/test reconciler-tests
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pierDipi, rahulii
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [pierDipi]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thanks @rahulii