eventing
eventing copied to clipboard
Reconcile EventPolicies when features configmap changes
Update the EventPolicy reconciler to reconcile all EventPolicies when the features configmap changes (e.g. when OIDC gets disabled)
/cc @dharmjit @pierDipi
@creydr: GitHub didn't allow me to request PR reviews from the following users: dharmjit.
Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
Update the EventPolicy reconciler to reconcile all EventPolicies when the features configmap changes (e.g. when OIDC gets disabled)
/cc @dharmjit @pierDipi
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
Project coverage is 67.89%. Comparing base (
3b1bfb4) to head (9d1f449). Report is 2 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| pkg/reconciler/eventpolicy/controller.go | 63.63% | 2 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #8059 +/- ##
==========================================
- Coverage 67.89% 67.89% -0.01%
==========================================
Files 366 366
Lines 17115 17125 +10
==========================================
+ Hits 11621 11627 +6
- Misses 4773 4775 +2
- Partials 721 723 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/cc @Leo6Leo
/cc @rahulii
@creydr: GitHub didn't allow me to request PR reviews from the following users: rahulii.
Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @rahulii
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@dharmjit: changing LGTM is restricted to collaborators
In response to this:
LGTM, thanks for catching and implementing this gap.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: creydr, dharmjit, matzew
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [creydr,matzew]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment