eventing icon indicating copy to clipboard operation
eventing copied to clipboard

[WIP] Merge Redundant TLS & OIDC e2e Tests

Open prajjwalyd opened this issue 1 year ago • 5 comments

Addresses #7638

Proposed Changes

  • :broom: merged TestParallelTLS & TestParallelTwoBranchesWithOIDC into TestParallelTLSAndOIDC
  • :broom: merged TestPingSourceTLS & TestPingSourceSendsEventsOIDC into TestPingSourceTLSAndOIDC

Pre-review Checklist

  • [ ] At least 80% unit test coverage
  • [ ] E2E tests for any new behavior
  • [ ] Docs PR for any user-facing impact
  • [ ] Spec PR for any new API feature
  • [ ] Conformance test for any change to the spec

Release Note


Docs

prajjwalyd avatar Jun 20 '24 20:06 prajjwalyd

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prajjwalyd Once this PR has been reviewed and has the lgtm label, please assign cardil for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jun 20 '24 20:06 knative-prow[bot]

Welcome @prajjwalyd! It looks like this is your first PR to knative/eventing 🎉

knative-prow[bot] avatar Jun 20 '24 20:06 knative-prow[bot]

Hi @prajjwalyd. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Jun 20 '24 20:06 knative-prow[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.92%. Comparing base (f84a98c) to head (bbe334c). Report is 112 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8017      +/-   ##
==========================================
+ Coverage   67.79%   67.92%   +0.13%     
==========================================
  Files         363      367       +4     
  Lines       16899    17323     +424     
==========================================
+ Hits        11456    11767     +311     
- Misses       4735     4823      +88     
- Partials      708      733      +25     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 04 '24 13:07 codecov[bot]

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Oct 03 '24 01:10 github-actions[bot]