eventing icon indicating copy to clipboard operation
eventing copied to clipboard

List applying policies in Parallel `.status.policies`

Open creydr opened this issue 1 year ago • 8 comments

As the Eventing Authorization feature track describes, target resources of EventPolicies, will reflect in their status, which EventPolicy is applied to them.

For example:

apiVersion: flows.knative.dev/v1
kind: Parallel
metadata:
  name: my-parallel
spec:
  ...
status:
  ...
  policies:
    - name: event-policy
      apiVersion: v1alpha1
    - name: another-event-policy
      apiVersion: v1alpha1

  conditions:
    - type: Ready
      status: "True"
    - type: EventPoliciesReady
      status: "True"

As the Parallel should support EventPolicies, wee need to do the following:

  • Update the Parallel reconciler to show applying policies in the Parallel .status.policies and set the Parallel EventPoliciesReady condition. Also watch EventPolicies for changes.
  • Set EventPoliciesReady condition to true, in case no policy applies, and set message according to the default-authorization-mode (e.g. Default authorization mode is 'allow-all'). Check the Default Authorization Mode section in the feature track for additional information.

Hint:

  • Adding AppliedEventPoliciesStatus to the Parallel is done in #7975

Prerequisites:

  • #7985
  • #7975

Additional hints for new contributors before starting with this issue:

  1. When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
  2. Make sure you've read and understood the CONTRIBUTING.md guidelines
  3. Make sure you're able to run Knative Eventing locally and run at least the unit tests.
  4. Feel free to raise any questions you have either directly here in the issue, in the #knative-eventing Slack channel or join the Eventing Workgroup Meeting
  5. When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.

creydr avatar Jun 10 '24 08:06 creydr

/assign

varshith257 avatar Jun 13 '24 15:06 varshith257

Hey @varshith257, This issue is ready to be worked on. You can also check on #8014, how we solved this for the Channel (particularly on https://github.com/knative/eventing/pull/8014/commits/b7ff773d20de19d1e7a278103f4a6a14d7e06f9b and https://github.com/knative/eventing/pull/8014/commits/789113828e15b3a27434667a74e98e04a9aefa8d). Please let us know if you have any questions :)

creydr avatar Jun 24 '24 14:06 creydr

Thanks! Will fix it soon

On Mon, 24 Jun, 2024, 8:29 pm Christoph Stäbler, @.***> wrote:

Hey @varshith257 https://github.com/varshith257, This issue is ready to be worked on. You can also check on #8014 https://github.com/knative/eventing/pull/8014, how we solved this for the Channel (particularly on b7ff773 https://github.com/knative/eventing/commit/b7ff773d20de19d1e7a278103f4a6a14d7e06f9b and 7891138 https://github.com/knative/eventing/commit/789113828e15b3a27434667a74e98e04a9aefa8d ). Please let us know if you have any questions :)

— Reply to this email directly, view it on GitHub https://github.com/knative/eventing/issues/7979#issuecomment-2186786256, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4BF3HBGFJMH3BTCKKYRSOLZJAX6PAVCNFSM6AAAAABJB2L2CGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBWG44DMMRVGY . You are receiving this because you were mentioned.Message ID: @.***>

varshith257 avatar Jun 24 '24 15:06 varshith257

Hello @varshith257 , Any updates on this? As this issue in in iteration 2 which ends next week (July 6th), please let us know if you'll be able to finish it till then (please also count some time for review cycles). If you don't find time for it, please unassign yourself, so that another contributor could pick this up.

creydr avatar Jun 28 '24 09:06 creydr

@creydr Yes I will complete it soon and raise PR by tommorow. I have exams so hadn't done any progress on this. Sorry for it

varshith257 avatar Jun 28 '24 10:06 varshith257

Hey @varshith257, thanks for the update. Good luck with your exams. I only wanted to make sure that we're aligned on the timeline

creydr avatar Jun 28 '24 10:06 creydr

hey @varshith257 since this is due end of this week and we are running short of time, would you mind if I assign the issue to myself? You can pick other issues once your exams are over ?

rahulii avatar Jul 01 '24 12:07 rahulii

@rahulii Working on it. Will submit a PR soon abiding timeline

varshith257 avatar Jul 01 '24 12:07 varshith257

@rahulii: As we didn't see any progress on this, I think you can take this over if you want

creydr avatar Jul 08 '24 08:07 creydr

/assign

rahulii avatar Jul 08 '24 08:07 rahulii

/unassign @varshith257

rahulii avatar Jul 08 '24 08:07 rahulii