CrossNamespace: e2e test to verify event delivery for broker and trigger

[yijie-04]

Fixes #7927

Proposed Changes

We should have an e2e test to verify that event delivery for broker and trigger when they are in different namespaces.

• :gift: Add new feature

Pre-review Checklist

• [ ] At least 80% unit test coverage
• [ ] E2E tests for any new behavior
• [ ] Docs PR for any user-facing impact
• [ ] Spec PR for any new API feature
• [ ] Conformance test for any change to the spec

Release Note

Docs

[yijie-04]

/cc @Cali0707 @pierDipi

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 22.22222% with 35 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (9eed163) to head (e440cb1). Report is 1 commits behind head on main.

Files	Patch %	Lines
pkg/broker/filter/filter_handler.go	8.82%	30 Missing and 1 partial :warning:
pkg/reconciler/broker/trigger/controller.go	50.00%	1 Missing and 2 partials :warning:
pkg/reconciler/sugar/trigger/controller.go	66.66%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7933      +/-   ##
==========================================
- Coverage   67.85%   67.80%   -0.05%     
==========================================
  Files         367      367              
  Lines       17356    17377      +21     
==========================================
+ Hits        11777    11783       +6     
- Misses       4844     4859      +15     
  Partials      735      735              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[pierDipi]

/test reconciler-tests

[Cali0707]

Hey @yijie-04 if you look at the error in the failing reconciler test, it looks like you might have missed adding the broker to one of the trigger.Install calls

[Cali0707]

/test reconciler-tests

Looks like the last failure was at least partially due to infra problems

[pierDipi]

is there any update for this PR?

[yijie-04]

is there any update for this PR?

I'm a bit stuck on figuring out what's crashing the tests :( Do you have any suggestions on where I should look into?

[Cali0707]

/test reconciler-tests

[Cali0707]

/test reconciler-tests

[Cali0707]

@yijie-04 can you rebase this PR?

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, yijie-04

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [Cali0707]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[yijie-04]

/test reconciler-tests

[Cali0707]

/cc @Leo6Leo

Can you TAL? I've added a decent amount of my code to this PR so it would be good to get the final LGTM from someone else

[yijie-04]

@Cali0707 I think there are also some tab/space issues for the license

[Cali0707]

/retest

[yijie-04]

/test reconciler-tests

[yijie-04]

/retest

[Leo6Leo]

/lgtm