eventing
eventing copied to clipboard
[WIP] CrossNamespace: Data Plane Changes for Broker Filter
Data plane changes are needed for the broker filter to correctly reference to brokers in the case of cross namespace referencing.
Proposed Changes
- :gift: Add new feature
Pre-review Checklist
- [ ] At least 80% unit test coverage
- [ ] E2E tests for any new behavior
- [ ] Docs PR for any user-facing impact
- [ ] Spec PR for any new API feature
- [ ] Conformance test for any change to the spec
Release Note
Docs
/cc @pierDipi @Cali0707
Codecov Report
Attention: Patch coverage is 10.00000% with 18 lines in your changes are missing coverage. Please review.
Project coverage is 68.96%. Comparing base (
7e1c082) to head (49aa6bc). Report is 52 commits behind head on main.
:exclamation: Current head 49aa6bc differs from pull request most recent head d164904
Please upload reports for the commit d164904 to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| pkg/broker/filter/filter_handler.go | 10.00% | 16 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #7913 +/- ##
==========================================
- Coverage 69.22% 68.96% -0.26%
==========================================
Files 339 341 +2
Lines 19494 15869 -3625
==========================================
- Hits 13494 10944 -2550
+ Misses 5337 4249 -1088
- Partials 663 676 +13
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Cali0707 @pierDipi Do you think we should have a test case with BrokerRef here?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Cali0707, yijie-04
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Cali0707]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment