eventing
eventing copied to clipboard
Refactor NewFiltersFeatureSet to prevent starvation
Fixes #7910
Proposed Changes
- Run installation of Sink, Broker and Trigger sequentially where required so as to prevent resource starvation
Pre-review Checklist
- [ ] At least 80% unit test coverage
- [ ] E2E tests for any new behavior
- [ ] Docs PR for any user-facing impact
- [ ] Spec PR for any new API feature
- [ ] Conformance test for any change to the spec
Release Note
Docs
Eventing Kafka Broker tests will be failing after merging this (and updating deps in EKB), the fix for EKB should be done in this way: https://github.com/mgencur/eventing-kafka-broker/commit/9428b799a999005f7613f52e60cc79e48968239a
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.02%. Comparing base (
7e1c082
) to head (245c60f
). Report is 35 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #7911 +/- ##
==========================================
- Coverage 69.22% 69.02% -0.20%
==========================================
Files 339 341 +2
Lines 19494 15853 -3641
==========================================
- Hits 13494 10943 -2551
+ Misses 5337 4236 -1101
- Partials 663 674 +11
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: creydr, mgencur
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~test/OWNERS~~ [creydr]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment