eventing
eventing copied to clipboard
Refactor NewFiltersFeatureSet to prevent starvation
The feature set NewFiltersFeatureSet runs a lot of tests in parallel. It also sets up a lot of Brokers, Triggers/Filters, Sink receivers in the same "Setup" phase of the reconciler-test framework. As a result, running the test suite with limited resources might result in phases timing out. Typically, a Trigger waits for a sink service that is not yet started and times out.
This feature set should be refactored so that steps that depend on each other should be run sequentially. For example, setup the receiver service, Broker and Trigger sequentially in a single "Setup" step instead of running them in small steps in parallel.
This should help stabilize test suites in this repository (see flakes) as well as https://github.com/knative-extensions/eventing-kafka-broker where this feature set is reused.
Describe the bug Tests timing out as described above, sometimes making the whole test suite fail.
Expected behavior Passing/stable test/rekt.TestMTChannelBrokerNewTriggerFilters
To Reproduce This happens from time to time when running the test suite for triggers/filters, see https://github.com/knative/eventing/issues/7717
Knative release version
Additional context Add any other context about the problem here such as proposed priority
/assign