eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Fix the naming convention in the config-features.yaml

Open Leo6Leo opened this issue 2 years ago • 4 comments

Proposed Changes

  • Instead of using ., we use -, otherwise it might cause error when using yq

Pre-review Checklist

  • [ ] At least 80% unit test coverage
  • [ ] E2E tests for any new behavior
  • [ ] Docs PR for any user-facing impact
  • [ ] Spec PR for any new API feature
  • [ ] Conformance test for any change to the spec

Release Note


Docs

Leo6Leo avatar Mar 05 '24 21:03 Leo6Leo

/cc @creydr @matzew

Leo6Leo avatar Mar 05 '24 21:03 Leo6Leo

@Leo6Leo can you fix the unit test?

creydr avatar Mar 06 '24 07:03 creydr

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.11%. Comparing base (95996a0) to head (87a2ea9). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7743   +/-   ##
=======================================
  Coverage   69.11%   69.11%           
=======================================
  Files         339      339           
  Lines       19398    19398           
=======================================
  Hits        13406    13406           
  Misses       5330     5330           
  Partials      662      662           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 06 '24 16:03 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Mar 06 '24 19:03 knative-prow[bot]