eventing
eventing copied to clipboard
Autocreated eventtypes reference trigger when the event is a reply
Fixes #7698
Proposed Changes
- Add eventtype autocreate handler to filter handler
- Use the autocreate handler to create a new eventtype when there is a reply
Pre-review Checklist
- [ ] At least 80% unit test coverage
- [ ] E2E tests for any new behavior
- [ ] Docs PR for any user-facing impact
- [ ] Spec PR for any new API feature
- [ ] Conformance test for any change to the spec
Release Note
EventTypes are now autocreated referencing the trigger when an event is a reply to the trigger
Docs
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Cali0707
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Cali0707]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
Attention: Patch coverage is 17.24138% with 24 lines in your changes are missing coverage. Please review.
Project coverage is 68.97%. Comparing base (
a154f1a) to head (2dc5f5f).
| Files | Patch % | Lines |
|---|---|---|
| cmd/broker/filter/main.go | 0.00% | 14 Missing :warning: |
| pkg/broker/filter/filter_handler.go | 33.33% | 9 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #7710 +/- ##
==========================================
- Coverage 69.04% 68.97% -0.08%
==========================================
Files 338 338
Lines 19350 19375 +25
==========================================
+ Hits 13360 13363 +3
- Misses 5328 5349 +21
- Partials 662 663 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/cc @pierDipi @matzew @Leo6Leo @dsimansk
/hold
@Cali0707: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| reconciler-tests_eventing_main | 2dc5f5f7f28e74fd5f5a5e017d722d79e7e9ed44 | link | true | /test reconciler-tests |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Afaik, superseded by https://github.com/knative/eventing/pull/7733, we can reopen if needed