eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Update eventtype v1beta3 type to reflect spec changes

Open Cali0707 opened this issue 1 year ago • 4 comments

Part of #7265

Proposed Changes

  • Update the eventtype CRD to have the new v1beta3 schema
  • Update the eventtype v1beta3 type and validation to reflect the new schema
  • Fix unit tests

Cali0707 avatar Feb 20 '24 16:02 Cali0707

/cc @dsimansk @matzew @pierDipi

Cali0707 avatar Feb 20 '24 16:02 Cali0707

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.22%. Comparing base (580f3c7) to head (2c3a610). Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7708      +/-   ##
==========================================
+ Coverage   69.04%   69.22%   +0.17%     
==========================================
  Files         338      339       +1     
  Lines       19350    19494     +144     
==========================================
+ Hits        13360    13494     +134     
- Misses       5328     5337       +9     
- Partials      662      663       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 20 '24 16:02 codecov[bot]

/cc @matzew @pierDipi @dsimansk

Cali0707 avatar Feb 27 '24 16:02 Cali0707

/cc @matzew @pierDipi

Any thoughts on this PR? Can we unhold, or are there more changes needed?

Cali0707 avatar Mar 11 '24 15:03 Cali0707

/cc @matzew @dsimansk

Cali0707 avatar Mar 18 '24 16:03 Cali0707

/cc @pierDipi

Cali0707 avatar Mar 25 '24 12:03 Cali0707

/test reconciler-tests

matzew avatar Mar 25 '24 15:03 matzew

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dsimansk, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Cali0707,dsimansk,pierDipi]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Mar 25 '24 18:03 knative-prow[bot]

/unhold

pierDipi avatar Mar 27 '24 15:03 pierDipi

/test reconciler-tests

pierDipi avatar Mar 27 '24 16:03 pierDipi

/test reconciler-tests

Cali0707 avatar Mar 27 '24 21:03 Cali0707

@Cali0707: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_main 2c3a610693df94661f94b251bb3bdc1d71217ff2 link unknown /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

knative-prow[bot] avatar Mar 27 '24 22:03 knative-prow[bot]

/test reconciler-tests

Cali0707 avatar Mar 28 '24 13:03 Cali0707