eventing
eventing copied to clipboard
chore: remove code duplicacy
Fixes #
Proposed Changes
Pre-review Checklist
- [ ] At least 80% unit test coverage
- [ ] E2E tests for any new behavior
- [ ] Docs PR for any user-facing impact
- [ ] Spec PR for any new API feature
- [ ] Conformance test for any change to the spec
Release Note
Docs
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sadath-12 Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Hi @sadath-12. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.29%. Comparing base (
bcba98a
) to head (80bc856
). Report is 127 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #7635 +/- ##
==========================================
- Coverage 74.44% 74.29% -0.16%
==========================================
Files 262 262
Lines 15077 15108 +31
==========================================
Hits 11224 11224
- Misses 3247 3278 +31
Partials 606 606
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/cc @Cali0707
@Cali0707 any updates here ?
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen
. Mark as fresh by adding the
comment /remove-lifecycle stale
.