eventing
eventing copied to clipboard
Move new trigger tests to conformance suite
Fixes #7625
Proposed Changes
- Move new trigger filter tests to conformance
- Update conformance main to use parsed rest config and pass it to the reconciler-test global environment
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Cali0707
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Cali0707]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/hold This required changes to reconciler-test vendor code to get the tests to run, so I need to merge a fix there first and rebase this PR. This just includes those changes to see why they are needed
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b0d9c13
) 74.54% compared to head (8cb9fb4
) 74.44%. Report is 21 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #7626 +/- ##
==========================================
- Coverage 74.54% 74.44% -0.11%
==========================================
Files 262 262
Lines 14965 15077 +112
==========================================
+ Hits 11156 11224 +68
- Misses 3219 3247 +28
- Partials 590 606 +16
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Cali0707: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
build-tests_eventing_main | 8cb9fb470e702a438b881b23aea8d164c730fd90 | link | true | /test build-tests |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@Cali0707 any updates on this one?
@Cali0707 any updates on this one?
@pierDipi I held off on updating this one since we decided that the filters wouldn't go GA until the CESQL stuff reaches a more stable spec version. I'll close this for now, and open a new one when that happens