eventing
eventing copied to clipboard
telepresence script added
Fixes #7099
Proposed Changes
Tried to automate the telepresence script.
Pre-review Checklist
- [ ] At least 80% unit test coverage
- [ ] E2E tests for any new behavior
- [ ] Docs PR for any user-facing impact
- [ ] Spec PR for any new API feature
- [ ] Conformance test for any change to the spec
Release Note
Docs
Hi @octonawish-akcodes. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c7520cc
) 74.56% compared to head (1ae14fb
) 73.98%. Report is 50 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #7589 +/- ##
==========================================
- Coverage 74.56% 73.98% -0.59%
==========================================
Files 262 262
Lines 14951 15178 +227
==========================================
+ Hits 11148 11229 +81
- Misses 3215 3343 +128
- Partials 588 606 +18
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/cc @Leo6Leo
@octonawish-akcodes I would suggest you try to run the script and test it in your local environment and in different operating systems (if applicable). Please let me know if there are any further questions
@octonawish-akcodes I would suggest you try to run the script and test it in your local environment and in different operating systems (if applicable). Please let me know if there are any further questions
I am testing the script on two platforms which I have ubuntu and windows (dual boot).
And one more thing that is worth of mentioning is that force push (git push --force
) is not a good idea and please don't use it when not necessary. Take a look at this blog post, and that might be helpful.
Hey @octonawish-akcodes Are there anything else we can help you with? Are you being blocked by anything?
And one more thing that is worth of mentioning is that force push (
git push --force
) is not a good idea and please don't use it when not necessary. Take a look at this blog post, and that might be helpful.
Oh I didn't knew about this, thanks for this. I'll keep it remember.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: octonawish-akcodes Once this PR has been reviewed and has the lgtm label, please ask for approval from leo6leo. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@octonawish-akcodes are you still interesting in continuing this PR?
Closing this PR for now as there is no update for a while