eventing
eventing copied to clipboard
knative
Dataplane conformance tests contain unimplemented test cases
The conformance tests for the Dataplane delivery contain a lot of test cases which still need to be implemented:
https://github.com/knative/eventing/blob/1ff36e1b656d3ae8d09c6e97fadbc745ec661f48/test/rekt/features/broker/data_plane.go#L107-L141
Same applies for the Dataplane observability tests:
https://github.com/knative/eventing/blob/1ff36e1b656d3ae8d09c6e97fadbc745ec661f48/test/rekt/features/broker/data_plane.go#L154-L169
These tests should be implemented.
@pierDipi: This request has been marked as needing help from a contributor.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
/help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![knative-prow[bot] avatar](https://avatars.githubusercontent.com/in/183726?v=4 "Published by a pub.dev verified publisher"){kind=small}
I would recommend to propose multiple PRs to address this issue instead of implementing all tests at once
If you taking a test you want to implement, please leave a comment on this issue for which unimplemented test / scenario you're working on, so that we don't duplicate work.
What's the status? Is this issue open for others to contribute or is everything handled in https://github.com/knative/eventing/pull/6811? It would be better if we can make a checklist in this issue if there are multiple things to tackle. (PS: i'm new here.)
Edit 1: It appears majority of good-first-issues are assigned to someone. I'll jump to help-wanted issues then.
Welcome @shubh220922, great to hear you are interested. @Vishal-Chdhry created a PR for this issue which is currently in review (#6811). @Vishal-Chdhry: Did you cover all the cases from this issue in your PR?
It seems there is a similar issue for Subscription conformance tests: #5782, on which nobody is assigned yet. Maybe this could be interested for you?
@shubh220922 There are some observability tests in broker and channel dataplane that you can work on https://github.com/knative/eventing/blob/7a90c46b4c70d1af8816de934f2d1c11c285c6d7/test/rekt/features/broker/data_plane.go#L154-L169
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@creydr: Reopened this issue.
In response to this:
/reopen /remove-lifecycle stale
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
@creydr: Reopened this issue.
In response to this:
/reopen /remove-lifecycle stale
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.