eventing
eventing copied to clipboard
Drop usage of `eventing.knative.dev/release`
Fixes #6383
Proposed Changes
- Removing deprecated eventing.knative.dev/release label
Pre-review Checklist
- [ ] At least 80% unit test coverage
- [ ] E2E tests for any new behavior
- [ ] Docs PR for any user-facing impact
- [ ] Spec PR for any new API feature
- [ ] Conformance test for any change to the spec
Release Note
'eventing.knative.dev/release' labels, deprecated in v1.3, have been removed. Switch it to using `app.kubernetes.io/name: knative-eventing` and `app.kuberentes.io/version: devel`.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: liuchangyan
Once this PR has been reviewed and has the lgtm label, please assign evankanderson for approval by writing /assign @evankanderson
in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Codecov Report
Merging #6488 (9925293) into main (cb3901f) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #6488 +/- ##
=======================================
Coverage 82.16% 82.16%
=======================================
Files 235 235
Lines 11700 11700
=======================================
Hits 9613 9613
Misses 1620 1620
Partials 467 467
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@houshengbo are you using this label in the operator?
/hold
let's not yet merge this a day before a release
ping @houshengbo
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen
. Mark as fresh by adding the
comment /remove-lifecycle stale
.