eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Drop usage of `eventing.knative.dev/release`

Open liuchangyan opened this issue 2 years ago • 5 comments

Fixes #6383

Proposed Changes

  • Removing deprecated eventing.knative.dev/release label

Pre-review Checklist

  • [ ] At least 80% unit test coverage
  • [ ] E2E tests for any new behavior
  • [ ] Docs PR for any user-facing impact
  • [ ] Spec PR for any new API feature
  • [ ] Conformance test for any change to the spec

Release Note

'eventing.knative.dev/release' labels, deprecated in v1.3, have been removed. Switch it to using `app.kubernetes.io/name: knative-eventing` and `app.kuberentes.io/version: devel`.

liuchangyan avatar Aug 18 '22 03:08 liuchangyan

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liuchangyan Once this PR has been reviewed and has the lgtm label, please assign evankanderson for approval by writing /assign @evankanderson in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Aug 18 '22 03:08 knative-prow[bot]

Codecov Report

Merging #6488 (9925293) into main (cb3901f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6488   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files         235      235           
  Lines       11700    11700           
=======================================
  Hits         9613     9613           
  Misses       1620     1620           
  Partials      467      467           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 18 '22 03:08 codecov[bot]

@houshengbo are you using this label in the operator?

pierDipi avatar Aug 18 '22 07:08 pierDipi

/hold

let's not yet merge this a day before a release

matzew avatar Aug 22 '22 16:08 matzew

ping @houshengbo

pierDipi avatar Sep 19 '22 14:09 pierDipi

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Dec 19 '22 01:12 github-actions[bot]