eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Knative port sink binding v1 job test to rekt

Open liuchangyan opened this issue 2 years ago • 2 comments

Proposed Changes

  • Port SinkbindingV1Job test to rekt

Pre-review Checklist

  • [ ] At least 80% unit test coverage
  • [ ] E2E tests for any new behavior
  • [ ] Docs PR for any user-facing impact
  • [ ] Spec PR for any new API feature
  • [ ] Conformance test for any change to the spec

Release Note

Add Job resource to rekt, and Port SinkbindingV1Job test to rekt

liuchangyan avatar Aug 13 '22 16:08 liuchangyan

Codecov Report

Merging #6481 (46fa54b) into main (4e56370) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6481   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files         235      235           
  Lines       11700    11700           
=======================================
  Hits         9613     9613           
  Misses       1620     1620           
  Partials      467      467           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 13 '22 16:08 codecov[bot]

/lgtm /approve

thanks!!

lionelvillard avatar Aug 15 '22 12:08 lionelvillard

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, liuchangyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Aug 15 '22 12:08 knative-prow[bot]