eventing icon indicating copy to clipboard operation
eventing copied to clipboard

[WIP] Make sure tracer is shut down across components

Open mgencur opened this issue 2 years ago • 3 comments

Fixes #

This is to show the effect of https://github.com/knative/pkg/pull/2566.

Proposed Changes

  • Setup Trace publishing and return the tracer which is later shutdown at the end of the process.

Pre-review Checklist

  • [ ] At least 80% unit test coverage
  • [ ] E2E tests for any new behavior
  • [ ] Docs PR for any user-facing impact
  • [ ] Spec PR for any new API feature
  • [ ] Conformance test for any change to the spec

Release Note


Docs

mgencur avatar Aug 05 '22 07:08 mgencur

Codecov Report

Merging #6474 (f8f5e21) into main (1d00055) will decrease coverage by 0.06%. The diff coverage is 73.91%.

@@            Coverage Diff             @@
##             main    #6474      +/-   ##
==========================================
- Coverage   82.16%   82.09%   -0.07%     
==========================================
  Files         235      235              
  Lines       11700    11714      +14     
==========================================
+ Hits         9613     9617       +4     
- Misses       1620     1628       +8     
- Partials      467      469       +2     
Impacted Files Coverage Δ
pkg/reconciler/broker/controller.go 85.00% <50.00%> (+0.25%) :arrow_up:
cmd/event_display/main.go 58.06% <66.66%> (+4.49%) :arrow_up:
pkg/adapter/v2/main_message.go 45.16% <66.66%> (-5.69%) :arrow_down:
...econciler/inmemorychannel/dispatcher/controller.go 88.46% <66.66%> (+0.30%) :arrow_up:
pkg/adapter/v2/configurator_configmap.go 82.44% <75.00%> (+0.18%) :arrow_up:
pkg/adapter/v2/configurator_environment.go 79.16% <75.00%> (-6.55%) :arrow_down:
pkg/adapter/v2/config.go 81.70% <100.00%> (ø)
pkg/adapter/v2/main.go 68.13% <100.00%> (+0.15%) :arrow_up:
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 05 '22 07:08 codecov[bot]

The failures in "Downstream / Unit Test (eventing-autoscaler-keda, knative-sandbox)" is not related to this PR, I believe.

mgencur avatar Aug 18 '22 06:08 mgencur

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Aug 22 '22 13:08 knative-prow[bot]