eventing
eventing copied to clipboard
A couple of unit test cases are flaky
Describe the bug There are two unit test can't pass in [eventing-kafka-broker ] and [ eventing-natss ] (1) The Error of Unit Test (eventing-kafka-broker, knative-sandbox) is
test/e2e_new/resources/kafkasink/kafkasink_test.go:44:36: not enough arguments in call to manifest.ExecuteYAML
have (embed.FS, map[string]string, map[string]interface {})
want (context.Context, fs.FS, map[string]string, map[string]interface {})
(2) The Error of Unit Test (eventing-natss, knative-sandbox) is
test/e2e/main_test.go:51:38: not enough arguments in call to "knative.dev/reconciler-test/pkg/environment".ProduceImages
have ()
want (context.Context)
Expected behavior The test cases can consistently pass.
To Reproduce
Run CI and see unit-tests
job
@cardil is working on some PRs similar to https://github.com/knative/eventing/commit/c8435ed74ba8716c38811382b6284ab090dfbf7b to fix these issues.