eventing
eventing copied to clipboard
fix 'host lookup failure' in tracing
Fix issue #6456
Pre-review Checklist
- [ ] At least 80% unit test coverage
- [ ] E2E tests for any new behavior
- [ ] Docs PR for any user-facing impact
- [ ] Spec PR for any new API feature
- [ ] Conformance test for any change to the spec
Release Note
when I check tracing of pingsource and mt-broker-controller, both of them have this bug:
host lookup failure: lookup pingsource.knative-eventing on 10.96.0.10:53: no such host
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: liuchangyan
To complete the pull request process, please assign lberk after the PR has been reviewed.
You can assign the PR to them by writing /assign @lberk
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Hi @liuchangyan. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
Merging #6459 (1739a80) into main (c8435ed) will decrease coverage by
0.00%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #6459 +/- ##
==========================================
- Coverage 82.15% 82.15% -0.01%
==========================================
Files 235 235
Lines 11694 11693 -1
==========================================
- Hits 9607 9606 -1
Misses 1620 1620
Partials 467 467
Impacted Files | Coverage Δ | |
---|---|---|
pkg/adapter/v2/configurator_configmap.go | 82.16% <0.00%> (-0.10%) |
:arrow_down: |
pkg/reconciler/broker/controller.go | 84.74% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/ok-to-test
@liuchangyan: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.