eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Bump HorizontalPodAutoscaler from deprecated v2beta2 to v2

Open pierDipi opened this issue 2 years ago • 8 comments

Problem

I'm getting this warning on k8s 1.23:

Warning: autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler

on

Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.0", GitCommit:"c2b5237ccd9c0f1d600d3072634ca66cefdf272f", GitTreeState:"clean", BuildDate:"2021-08-04T18:03:20Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-26T08:02:07Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}

Persona: Which persona is this feature for? *

Exit Criteria A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional): How many developer-days do you think this may take to resolve? 1

pierDipi avatar Apr 14 '22 12:04 pierDipi

/triage accepted /good-first-issue

pierDipi avatar May 02 '22 07:05 pierDipi

@pierDipi: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/triage accepted /good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar May 02 '22 07:05 knative-prow[bot]

/assign

gab-satchi avatar Jun 10 '22 13:06 gab-satchi

Hey @pierDipi, I think this needs to wait till after v1.6. Any way to move to that release?

The minimum supported k8s version for v1.6 is still v1.22 and autoscaling/v2 isn't available in that k8s release.

gab-satchi avatar Jun 10 '22 13:06 gab-satchi

@gab-satchi Hi, are you still working on this issue ? if not, I would like to take it.

liuchangyan avatar Jul 12 '22 02:07 liuchangyan

Hi @liuchangyan, this needs to wait for a min k8s version bump due to https://github.com/knative/eventing/pull/6424#issuecomment-1169601465.

This min k8s version bump is supposed to happen in 1.7 (today we are releasing 1.6), so we can start this after we have removed 1.22 from the KinD testing matrix and added 1.24

pierDipi avatar Jul 12 '22 08:07 pierDipi

is this still open and available to be taken?

amaanq avatar Sep 21 '22 17:09 amaanq

Hi @amaanq, yes, this is available to be taken

pierDipi avatar Sep 22 '22 08:09 pierDipi

@amaanq still interested in this? Otherwise I will take it

matzew avatar Sep 27 '22 07:09 matzew