eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Update trigger.spec.filters to the latest subscription API filters

Open pierDipi opened this issue 3 years ago • 4 comments

Problem

The subscription API has been updated to improve the UX in https://github.com/cloudevents/spec/pull/957

We should update the new-trigger-filter experimental feature to reflect that.

Persona: Which persona is this feature for? Event consumer

Exit Criteria

A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional): How many developer-days do you think this may take to resolve? 2

Additional context (optional)

/area brokers

pierDipi avatar Feb 24 '22 18:02 pierDipi

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar May 26 '22 01:05 github-actions[bot]

/remove-lifecycle stale

pierDipi avatar May 26 '22 07:05 pierDipi

I would like to work on this issue. /assign

daisy-ycguo avatar Aug 08 '22 06:08 daisy-ycguo

There is one missing update for https://github.com/knative/eventing/tree/main/pkg/eventfilter/subscriptionsapi to accept multiple entries for the updated filters (for example https://github.com/knative/eventing/blob/c884e27795f7db3caf44e69b128928450a7a6a54/pkg/eventfilter/subscriptionsapi/exact_filter.go#L39 accepts only one entry), so reopening for now.

pierDipi avatar Aug 09 '22 08:08 pierDipi