eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Source spec does require outdated fields for SPEC and STATUS

Open matzew opened this issue 3 years ago • 1 comments

Describe the bug

For sourceSpec and StatusSpec the "Sources Spec" does require still explicit fields for

  • Sink
  • CloudEventOverrides
  • Status
  • SinkURI

See here for reference: https://github.com/knative/eventing/blob/main/docs/spec/sources.md#source-custom-objects

However, looking at the code, the actual types now leverage the SourceSpec type for this. Two examples:

  • https://github.com/knative/eventing/blob/main/pkg/apis/sources/v1/apiserver_types.go#L53-L58
  • https://github.com/knative/eventing/blob/main/pkg/apis/sources/v1/ping_types.go#L54-L59

and the SourceStatus for the Status:

  • https://github.com/knative/eventing/blob/main/pkg/apis/sources/v1/apiserver_types.go#L94
  • https://github.com/knative/eventing/blob/main/pkg/apis/sources/v1/ping_types.go#L95

/assign @lionelvillard

matzew avatar Dec 03 '21 13:12 matzew

@matzew is this still relevant?

pierDipi avatar Mar 26 '24 10:03 pierDipi