eventing
eventing copied to clipboard
Source spec does require outdated fields for SPEC and STATUS
Describe the bug
For sourceSpec and StatusSpec the "Sources Spec" does require still explicit fields for
- Sink
- CloudEventOverrides
- Status
- SinkURI
See here for reference: https://github.com/knative/eventing/blob/main/docs/spec/sources.md#source-custom-objects
However, looking at the code, the actual types now leverage the SourceSpec type for this. Two examples:
- https://github.com/knative/eventing/blob/main/pkg/apis/sources/v1/apiserver_types.go#L53-L58
- https://github.com/knative/eventing/blob/main/pkg/apis/sources/v1/ping_types.go#L54-L59
and the SourceStatus for the Status:
- https://github.com/knative/eventing/blob/main/pkg/apis/sources/v1/apiserver_types.go#L94
- https://github.com/knative/eventing/blob/main/pkg/apis/sources/v1/ping_types.go#L95
/assign @lionelvillard
@matzew is this still relevant?