eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Sink URI resolver tests update

Open tzununbekov opened this issue 3 years ago • 7 comments

Sink resolver updated behavior introduced in knative/pkg#2322 requires v1.Service Informer injection to retrieve destination port details.

v1.Service informers manually injected and prepopulated with objects if they are required in the tests.

tzununbekov avatar Nov 08 '21 15:11 tzununbekov

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

knative-prow-robot avatar Nov 08 '21 15:11 knative-prow-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tzununbekov To complete the pull request process, please assign akashrv after the PR has been reviewed. You can assign the PR to them by writing /assign @akashrv in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot avatar Nov 08 '21 15:11 knative-prow-robot

Codecov Report

Merging #5880 (80c930f) into main (d5201e7) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5880   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files         220      220           
  Lines        7527     7527           
=======================================
  Hits         6174     6174           
  Misses        918      918           
  Partials      435      435           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5201e7...80c930f. Read the comment docs.

codecov[bot] avatar Nov 08 '21 15:11 codecov[bot]

@tzununbekov: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot avatar Nov 23 '21 21:11 knative-prow-robot

@tzununbekov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-eventing-reconciler-tests 80c930fd4322542fa2795631d4471993964bfa9d link true /test pull-knative-eventing-reconciler-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

knative-prow-robot avatar Mar 23 '22 14:03 knative-prow-robot

@iph-53: changing LGTM is restricted to collaborators

In response to this:

A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar May 20 '22 23:05 knative-prow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iph-53, tzununbekov To complete the pull request process, please assign akashrv after the PR has been reviewed. You can assign the PR to them by writing /assign @akashrv in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 20 '22 23:05 knative-prow[bot]

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Aug 19 '22 01:08 github-actions[bot]