eventing
eventing copied to clipboard
knative
Need some refactor regarding the triggers, brokers and channel naming, code and methods
Problem Need some refactor regarding the triggers, brokers and channel naming, code and methods. Following up #5824 issue, there are some inconsistent naming convention around DeadLetterSinks. This including crds and testing methods, variables and descriptions.
Some examples can be found in this PR where some of this details are around some of the commits, but it was decided to separate those concerns into a separate issue and PR so they don't mix.
Persona: Developers
Exit Criteria Improve variables and method names redability regarding Triggers, Channels and Brokers DLS
Thanks for taking care of this!
Could we have better descriptions of the problem and links to comments at other issues/PRs so that:
- we can scope what needs to be done here.
- anyone reviewing does not need to follow all previous history of status fixes (I think this issue is related to those)
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
It is but is not urgent, we have lots of repeating code and naming inconsistencies in the broker's, trigger's, channel's and subscription's code. Let me finish some things I have for this week and try to put concrete cases in this issue.
Hi, if this issue is still relevant I would like to work on it. Seems to me that Dead Letter Sink(DLS) was previously called Dead Letter Queue(DLQ) in the code. And because of this, word 'DLQ' has been used at multiple locations in code and needs to be replaced with DLS for consistency. Am I correct?
Closing this issue for now as it's not clear what needs to be done exactly.
Thanks for the interesting @garg-dhruv