Subscription Conformance Tests completion

[gabo1208]

Problem We don't have all the MUST clauses in the Subscription spec covered by tests in the project, for example: https://github.com/knative/eventing/blob/792f56ddb5e2328005149e7af571be6ca667cd89/test/rekt/features/channel/data_plane.go lots of todo in .must clauses in this file. Same with the other CRDs (Subscription, Broker, Trigger)

Persona: Developers

Exit Criteria Have at least one test per MUST clause from the Subscription specs

Additional context (optional) This is part of the Conformance GA plan

[github-actions[bot]]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

[pierDipi]

/remove-lifecycle stale /triage accepted

[daisy-ycguo]

Who can add more details of this issue? What kind of tests? Does it mean to add unit tests or validation tests? What's MUST cause in subscription spec? It will be helpful to add a link to a "MUST cause" sample here. Thanks.

[gabo1208]

Yep, edited the issue with more context =)

[daisy-ycguo]

I'm working on broker's conformance tests. /assign

[daisy-ycguo]

@gabo1208 will you check if my PR satisfied your requeirments? If it is, I could provide more conformance tests.

[gabo1208]

Of course tomorrow morning I'll check it out :) thanks for the ping @daisy-ycguo

[pierDipi]

/good-first-issue

I'd recommend to split the solution for this issue in multiple PRs, one for each scenario

[knative-prow[bot]]

@pierDipi: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

I'd recommend to split the solution for this issue in multiple PRs, one for each scenario

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[garg-dhruv]

/assign

[vishal-chdhry]

@gabo1208 I am working on Broker Conformance tests and Channel Input tests

[ThatSneakyCoder]

/assign

[sadath-12]

/assign

[sadath-12]

@gabo1208 shall I take the responsibility of filling all the todo's there into 2 pr's addDataPlaneDelivery and observability

[gabo1208]

Ideally yes, but any progress is appreciated!