eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Allow Metadata Configuration in ChannelTemplateSpec

Open GarrettPoore opened this issue 2 years ago • 9 comments

Problem ChannelTemplateSpec only allows setting of the spec for the Channel, but in some cases it may be useful to set some metadata for the Channel as well.

My specific use case is with the KafkaChannel, which has the eventing.knative.dev/scope annotation to change where the Kafka dispatcher is run (cluster/namespace).

Persona: System Integrator

Exit Criteria A ChannelTemplateSpec can configure metadata of the Channel created by a Broker.

GarrettPoore avatar Sep 15 '21 17:09 GarrettPoore

I'm wondering if a possible spec update should include Annotations only or Labels are also could be of interest.

tzununbekov avatar Oct 29 '21 13:10 tzununbekov

/assign

tzununbekov avatar Nov 17 '21 12:11 tzununbekov

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Feb 16 '22 01:02 github-actions[bot]

/remove-lifecycle stale

pierDipi avatar Feb 16 '22 17:02 pierDipi

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar May 18 '22 01:05 github-actions[bot]

I won't have cycles for this issue any time soon, sorry.

/unassign /remove-lifecycle stale

tzununbekov avatar May 18 '22 05:05 tzununbekov

/triage accepted

pierDipi avatar May 23 '22 07:05 pierDipi

/assign

liuchangyan avatar Oct 31 '22 03:10 liuchangyan

I'm wondering if a possible spec update should include Annotations only or Labels are also could be of interest.

Yes, labels are interesting as well, e.g. we need to set a label for log collector.

astelmashenko avatar May 17 '23 11:05 astelmashenko