eventing
eventing copied to clipboard
knative
[QE] Passing a custom config template for upgrade tests is limiting (and cumbersome)
Describe the bug The PR #4615 have introduced a way to pass a custom config template. But, passing it is limited to a relative path of default config.toml file.
This is cumbersome, as seen in: https://github.com/google/knative-gcp/blob/930cae634aa9fdb1ee5064091680668e3711f236/test/upgrade/continual.go#L45-L46 (cc @zhongduo), and can be used only with vendored sources.
Expected behavior It should be easy to pass a custom config path, even outside of vendor path.
Knative release version v0.20.0 +
@cardil are you working on this now? Do you expect to get it in by next release (0.23) or after that?
Not so actively. I think I'll propose some solution, but i think after 0.23.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
