knative
When search bar is expanded it causes top section titles to be scrunched
You can see in the below image the top section titles and version picker and skewed
I noticed that this header misalignment doesn’t happen when running knative/docs locally — it only shows up on the deployed site.
Could someone from the team confirm if this is managed outside of knative/docs ?
cc @dprotaso @thisisobate
hey @rohan-019 - I think the netlify preview doesn't use this script - https://github.com/knative/docs/blob/main/hack/build.sh
Thanks for clarifying! That makes sense — I’ll start working on this issue and explore updating the Netlify build config to use build.sh so it matches the local environment. I’ll share updates here. cc @dprotaso
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @evankanderson @dprotaso I have checked the issue against the official website, It seems it has been resolved, Please verify, I believe, this issue can be closed.
Thank you.
@codeEvolveZenith345 what browser are you using? I still see it on knative.dev
https://github.com/user-attachments/assets/60a5a070-3d7c-4895-902b-fbf29da1161a
Hi @dprotaso I experienced the same behavior as you attached in screen recording, But the version overlap with the nav attributes is no longer persisting as was in the image in the description... There is no activity from @rohan-019 , perhaps he might link a PR as assignee,
@dprotaso However, what is the expected outcome to resolve the issue?
Hey @codeEvolveZenith345 I think we should keep things simple and just have the navigation remain static.
For example visit the website of the theme we are using. https://squidfunk.github.io/mkdocs-material/tutorials/
When you click on the search bar it expands and is over top of the navigation
Hey @codeEvolveZenith345 I think we should keep things simple and just have the navigation remain static.
Ageed!
For example visit the website of the theme we are using. https://squidfunk.github.io/mkdocs-material/tutorials/
This looks good for reference but, The current content does not align with this reference, I mean
currently search bar expansion on /knative.dev hides the title too, here in the reference the title is unchanged,
Also. about the elements beside the searchbar like Home etc, are not in the reference,
So I guess you mean:
- keep the title,
- expand the searchbar
- searchbar should overlay the elements like Home etc,
@dprotaso should we wait for @rohan-019 ? As he was assigned, although there is no activity on it since a long time...
Hey @codeEvolveZenith345 — I’m not working on this at the moment, so feel free to take it over.
Hey @codeEvolveZenith345 I think we should keep things simple and just have the navigation remain static.
Ageed!
For example visit the website of the theme we are using. https://squidfunk.github.io/mkdocs-material/tutorials/
This looks good for reference but, The current content does not align with this reference, I mean currently search bar expansion on
/knative.devhides the title too, here in the reference the title is unchanged, Also. about the elements beside the searchbar like Home etc, are not in the reference, So I guess you mean:
- keep the title,
- expand the searchbar
- searchbar should overlay the elements like Home etc,
Hi @dprotaso Please answer these follow-ups for me to work in an accurate direction!
I guess you mean:
keep the title, expand the searchbar searchbar should overlay the elements like Home etc,
Yeah that sounds good