docs icon indicating copy to clipboard operation
docs copied to clipboard

feat: mount propagation documentation in feature flags

Open elijah-rou opened this issue 9 months ago • 4 comments

Adds mountPropagation to the features/extensions page. For https://github.com/knative/serving/pull/15758

elijah-rou avatar Feb 12 '25 02:02 elijah-rou

Welcome @elijah-rou! It looks like this is your first PR to knative/docs 🎉

knative-prow[bot] avatar Feb 12 '25 02:02 knative-prow[bot]

Deploy Preview for knative ready!

Name Link
Latest commit 4d670b37ade8859ea2a6b83dc7d5c11785997c45
Latest deploy log https://app.netlify.com/projects/knative/deploys/68f80055f5839600082356f0
Deploy Preview https://deploy-preview-6223--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Feb 12 '25 02:02 netlify[bot]

hey @elijah-rou just following up on this

dprotaso avatar May 18 '25 22:05 dprotaso

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Aug 17 '25 01:08 github-actions[bot]

@elijah-rou any chance you could address these docs changes?

dprotaso avatar Aug 20 '25 15:08 dprotaso

@elijah-rou just following up here

dprotaso avatar Sep 08 '25 13:09 dprotaso

Sorry about the merge -- in https://github.com/knative/docs/pull/6398 , I moved all the versioned documentation under versioned, to separate it from the blog, testimonials, community pages that are not version-specific. You should be able to just move these files to the new location; I didn't need to change any contents.

evankanderson avatar Sep 23 '25 18:09 evankanderson

Rebase the changes and simplified the diff

/cherry-pick release-1.19

dprotaso avatar Oct 21 '25 21:10 dprotaso

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

Rebase the changes and simplified the diff

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Oct 21 '25 21:10 knative-prow-robot

/lgtm /approve

dprotaso avatar Oct 21 '25 21:10 dprotaso

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, elijah-rou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Oct 21 '25 21:10 knative-prow[bot]

@dprotaso: new pull request created: #6465

In response to this:

Rebase the changes and simplified the diff

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Oct 21 '25 21:10 knative-prow-robot