docs icon indicating copy to clipboard operation
docs copied to clipboard

fix: sources table rendering

Open prushh opened this issue 1 year ago • 3 comments

Fixes #6139

Proposed Changes

  • add missing table delimiters (pipes)
  • update RedisSource url with knative-extensions/eventing-redis repository url

prushh avatar Oct 16 '24 14:10 prushh

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 8024a2331c220a9d2eda3a8ce2b20fb88811261f
Latest deploy log https://app.netlify.com/sites/knative/deploys/67168d2b3445cf000829d74c
Deploy Preview https://deploy-preview-6140--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 16 '24 14:10 netlify[bot]

Should I bump the RedisSource status to "Beta"? Ref: https://github.com/knative-extensions/eventing-redis?tab=readme-ov-file#redis-components-for-knative

Edit: Also let me know if I can fix the unit tests in this PR, I think it is only necessary to change the version of express in the Recreating the sample code section of this README.md

prushh avatar Oct 16 '24 14:10 prushh

Should I bump the RedisSource status to "Beta"? Ref: https://github.com/knative-extensions/eventing-redis?tab=readme-ov-file#redis-components-for-knative

Yes, it looks like the components are beta, so correcting that would be really helpful!

Edit: Also let me know if I can fix the unit tests in this PR, I think it is only necessary to change the version of express in the Recreating the sample code section of this README.md

I think it would be fine to fix it in either this PR or a new one

Cali0707 avatar Oct 21 '24 15:10 Cali0707

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, prushh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Oct 21 '24 18:10 knative-prow[bot]