docs icon indicating copy to clipboard operation
docs copied to clipboard

Add documentation for Eventing Authorization

Open creydr opened this issue 1 year ago • 3 comments

Fixes #6099

Proposed Changes

creydr avatar Aug 28 '24 10:08 creydr

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 993c2a39a6226ca92122df6dfdf9e02f30d4df99
Latest deploy log https://app.netlify.com/sites/knative/deploys/66d6a0de8ec45f0008ecd72c
Deploy Preview https://deploy-preview-6104--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 28 '24 10:08 netlify[bot]

/cc @pierDipi @matzew Could you give this an initial review? -> https://deploy-preview-6104--knative.netlify.app/docs/eventing/features/authorization/

creydr avatar Aug 28 '24 10:08 creydr

We probably want to wait for

  • https://github.com/knative-extensions/eventing-kafka-broker/issues/4038
  • https://github.com/knative-extensions/eventing-kafka-broker/issues/4039 before merging this, so that we have the full support in Eventing-Kafka-Broker

/hold

creydr avatar Aug 29 '24 08:08 creydr

I think for the filters, it's normally "All" of the filters that just be true for a specific policy, not one of the filters for a policy

Cali0707 avatar Aug 29 '24 17:08 Cali0707

/unhold as we enabled the support in EKB

creydr avatar Sep 02 '24 14:09 creydr

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Sep 03 '24 09:09 knative-prow[bot]

@pierDipi @lberk any other comments, or can we unhold this?

creydr avatar Sep 04 '24 07:09 creydr

/lgtm

Thanks!

pierDipi avatar Sep 05 '24 06:09 pierDipi

/unhold

creydr avatar Sep 05 '24 08:09 creydr