docs icon indicating copy to clipboard operation
docs copied to clipboard

implemented the new case study section of the home page

Open ShravaniAK opened this issue 1 year ago • 3 comments

Fixes #6031

implemented the new design of the case study section , did the following changes

  1. changed the background color of each case study to white.
  2. changed the font family and removed the italic style.
  3. added margin and padding .
  4. Changed the color of the horizontal line and the font.
  5. added box shadow effect on Hover .

Before : Screenshot 2024-06-28 at 2 40 41 PM

After: Screenshot 2024-06-28 at 2 40 55 PM

ShravaniAK avatar Jun 28 '24 09:06 ShravaniAK

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit f9950b7087233f916c42a2bea9ff94af2989172b
Latest deploy log https://app.netlify.com/sites/knative/deploys/66993b1b87960c00086643ff
Deploy Preview https://deploy-preview-6032--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 28 '24 09:06 netlify[bot]

/cc @zainabhusain227 @mmejia02

Cali0707 avatar Jun 28 '24 14:06 Cali0707

Hey @zainabhusain227 @mmejia02 when you have some time can you compare the preview to the designs and leave any feedback here?

Cali0707 avatar Jul 09 '24 13:07 Cali0707

@Cali0707 , I have implemented all the changes requested, except for the "incorporate the arrows" , I think that it's a new feature implementation that can be made in a new separate pr.

ShravaniAK avatar Jul 12 '24 07:07 ShravaniAK

Also for point 2 , I have fixed that in #6036

ShravaniAK avatar Jul 12 '24 07:07 ShravaniAK

@ShravaniAK it looks like this has some conflicts now that your other PR merged, would you mind fixing those?

Cali0707 avatar Jul 18 '24 15:07 Cali0707

@Cali0707 I have fixed the conflicts!

ShravaniAK avatar Jul 18 '24 15:07 ShravaniAK

Thanks @ShravaniAK ! There are a few issues that need fixing (see video below):

  1. When hovering over a case study, some of the text is shifted by the border
  2. The transition between no border and border should be animated

https://github.com/user-attachments/assets/0aecdff0-4733-478d-84b4-7dda9cff1e41

Cali0707 avatar Jul 18 '24 15:07 Cali0707

@Cali0707 I have fixed both the issues, can you please review them once again, Thanks!

ShravaniAK avatar Jul 18 '24 15:07 ShravaniAK

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, ShravaniAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jul 18 '24 16:07 knative-prow[bot]