docs icon indicating copy to clipboard operation
docs copied to clipboard

fix: Responsive Design Enhancements for Knative Docs Home Page

Open asr2003 opened this issue 1 year ago • 9 comments
trafficstars

  • Fixes #5876

Proposed Changes

Before:

image

image

image

image

image

After:

WhatsApp Image 2024-05-26 at 21 38 58_cfbe194b

WhatsApp Image 2024-05-26 at 21 39 43_fffd0ca9

WhatsApp Image 2024-05-26 at 21 40 25_a900817b

WhatsApp Image 2024-05-26 at 21 41 01_88a15fe0

WhatsApp Image 2024-05-26 at 21 41 13_2775f612

WhatsApp Image 2024-05-26 at 21 41 26_d757376a

asr2003 avatar May 26 '24 10:05 asr2003

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asr2003 Once this PR has been reviewed and has the lgtm label, please assign cali0707 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 26 '24 10:05 knative-prow[bot]

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 0ffe2886e5c63e30fbedc1292c6300ba27b977ac
Latest deploy log https://app.netlify.com/sites/knative/deploys/66535ac942c5530008b0c47c
Deploy Preview https://deploy-preview-5994--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 26 '24 10:05 netlify[bot]

@Cali0707 @zainabhusain227 I am almost done with changes outlined in the issue. PTAL

https://deploy-preview-5994--knative.netlify.app/

asr2003 avatar May 26 '24 16:05 asr2003

/review

asr2003 avatar May 26 '24 16:05 asr2003

hey @asr2003

This issue is part of an LFX project for this summer. If you're interested in the program, please focus on your proposal, instead of working on the project.

Thanks

aliok avatar May 27 '24 07:05 aliok

@aliok Thanks for the clarification. I had worked on it as part of contributing to the repo so that I can get familiar with the codebase and it will make to craft a good proposal. I think got misconception that this issue isn't linked in upstream issue.

asr2003 avatar May 27 '24 07:05 asr2003

/upstream

asr2003 avatar May 28 '24 14:05 asr2003

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Jun 27 '24 06:06 knative-prow-robot

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Sep 26 '24 01:09 github-actions[bot]