docs icon indicating copy to clipboard operation
docs copied to clipboard

Knative website design issues fixed

Open nafisreza opened this issue 1 year ago • 9 comments

"Implemented website redesign according to issue #134 of knative/ux" I have set up the project locally on my machine and started making improvements according to provided design.

Proposed Changes

  • Website color theme updated along with hover color/animation.
  • Right nav buttons are aligned with github logo and top border rounded.
  • Buttons are rounder with increased border radius.
  • Gap between two CTAs added.
  • SVG icons color updated according to new theme.
  • Font weights of all the content updated according to provided design.
  • In Knative components, text are aligned center.
  • Background color of 'Case Studies' changed along with the cards, necessary gap added and hover animation added.
  • Footer has 3 column spacing and font weight adjusted.
  • Social icons colors changed from gray to white..
  • Back to the top button border radius and box shadow updated
  • A few texts were broken down with
    tags, removed them to make texts single-lined.

Preview:

screencapture-127-0-0-1-8000-docs-2024-05-22-07_03_51

nafisreza avatar May 22 '24 01:05 nafisreza

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nafisreza Once this PR has been reviewed and has the lgtm label, please assign krsna-m for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 22 '24 01:05 knative-prow[bot]

Welcome @nafisreza! It looks like this is your first PR to knative/docs 🎉

knative-prow[bot] avatar May 22 '24 01:05 knative-prow[bot]

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 662d0edde6c5bf8ba549ed1ca9622bf5f8715a03
Latest deploy log https://app.netlify.com/sites/knative/deploys/664d460026d23b0008f796b1
Deploy Preview https://deploy-preview-5984--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 22 '24 01:05 netlify[bot]

hey @nafisreza

This task is part of LFX mentorship project. If you're interested in participating in that program, I would recommend working on your proposal instead of working on the actual task.

Thanks for your contribution! I will keep this PR on hold as I want to spend time on reviewing LFX mentee's PR.

aliok avatar May 23 '24 12:05 aliok

/hold

aliok avatar May 23 '24 12:05 aliok

Thanks @aliok for the reply. I have already submitted my proposal on LFX portal along with the necessary docs. Fingers crossed! :)

nafisreza avatar May 24 '24 01:05 nafisreza

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar May 29 '24 06:05 knative-prow-robot

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Aug 28 '24 01:08 github-actions[bot]