docs
docs copied to clipboard
fix: Website colour adjustments
- Fixes #5765
Proposed Changes
- Changed the root website dark and light blue to the following hex codes: -- Light Blue: 6593C8 -- Dark blue: 0D4984
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: asr2003 / name: Ambati Sahithi (5a590bbdba969c1bb28cac6cf1b4273ee7ba7df4, e32d86a7b63e3d79573dddeffe666cf6a3e3a573, 06bb021bfcf5dd34e50b47d96c98da90560c1c29, b845ea31fc8875a5d7e4411706d182f2a8b39c10, d04dde5285a30a9ef308073da90662370f01c4f4, 9dc9187e5d8e4a5e870d5142bb82587a638fd3f7)
Deploy Preview for knative ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 06bb021bfcf5dd34e50b47d96c98da90560c1c29 |
| Latest deploy log | https://app.netlify.com/sites/knative/deploys/6654a47faddfb6000876554e |
| Deploy Preview | https://deploy-preview-5980--knative.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@Cali0707 It's ready for your review. PTAL
@asr2003 could you sign the CLA? It should be the link in this comment
@Cali0707 Done with signing CLA.
@knative/ux-wg-leads is this PR good?
We will be approving the PRs during our next UX WG meeting. I have put the PR in the meeting agenda.
Update: As the PR is implementing the design that UX WG has agreed on, no need for approval during the meeting.
@Leo6Leo Thanks for putting this PR for next UX WG meeting. I will make sure to join the meeting and also I have some enhancements in my mind, can we discuss there or in slack?
@asr2003 Sure! Feel free to discuss here, or in the CNCF slack #knative-ux channel. If you think it worthy a discussion among the UX WG, you can put it on the UX WG meeting agenda here. Looking forward to having you join in our next meeting.
/approve /cc @mmejia02 @zainabhusain227
Color scheme suggestions (from most recent design system: https://www.figma.com/design/3CzqCQj0dDK1MuTZelUfFa/Knative-Design-System?node-id=101-2&t=CAlyHn4R4uSs4qr9-0)
Changed the root website dark and light blue to the following hex codes: -- Light Blue: #6695CA -- Dark blue: #0865AD
@asr2003 would you mind switching the colours to those @zainabhusain227 listed above?
Sure!
@zainabhusain227 @Cali0707 Updated with the changes suggested
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: asr2003, Cali0707, Leo6Leo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Cali0707,Leo6Leo]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Cali0707 Thanks for merging! I am following up with this PR to get merged from a week. Finally merged :)
Thanks @Cali0707 @Leo6Leo @zainabhusain227 for approving and special thanks to @aliok for an immediate response for getting reviews for this PR.